fix(CodeModal): Fix ResizeObserver loop completed with undelivered notifications issue#688
Merged
rebeccaalpert merged 1 commit intopatternfly:mainfrom Oct 20, 2025
Conversation
|
Preview: https://chatbot-pr-chatbot-688.surge.sh A11y report: https://chatbot-pr-chatbot-688-a11y.surge.sh |
075b1a4 to
626817b
Compare
…tifications issue This moves resize handling/detection to where we have control over it. We are able to put more control over it so it doesn't loop infinitely the way putting a code editor in a modal seems to do.
626817b to
f39c5e5
Compare
karthikjeeyar
approved these changes
Sep 30, 2025
Contributor
karthikjeeyar
left a comment
There was a problem hiding this comment.
I have verified the changes in RHDH by locally linking to the PR changes.
/approve
/lgtm
nicolethoen
approved these changes
Oct 9, 2025
|
🎉 This PR is included in version 6.5.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
rebeccaalpert
added a commit
to rebeccaalpert/virtual-assistant
that referenced
this pull request
Oct 24, 2025
…tifications issue (patternfly#688) This moves resize handling/detection to where we have control over it. We are able to put more control over it so it doesn't loop infinitely the way putting a code editor in a modal seems to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only seems visible when running code locally fwiw - shows up in runtime error overlay. You don't see it in Surge. Resize or zoom into an example with the code modal to fire the issue. (I used this one - open the code modal by clicking the attachment label in the existing message: http://localhost:8006/patternfly-ai/chatbot/messages/demo#attach-via-upload-button-in-message-bar).
When you use CodeEditor by itself, it has a container with predictable dimensions. I suspect this breaks down inside the PF modal since I've only seen it here. This moves resize handling/detection to where we have control over it, which seems to stop the issue.
The error message was showing up on the overlay panel, but doesn't seem harmful to me (interrupting infinite loop). Karthik from RHDH was able to link this and verify that this fixes the issue for him.