feat(MessageSnippets): added high contrast#733
feat(MessageSnippets): added high contrast#733thatblindgeye merged 4 commits intopatternfly:mainfrom
Conversation
|
Preview: https://chatbot-pr-chatbot-733.surge.sh A11y report: https://chatbot-pr-chatbot-733-a11y.surge.sh |
rebeccaalpert
left a comment
There was a problem hiding this comment.
I think Lucia also wanted the inline code block done since it's gray. Table looks great. We also want to handle the block quotes outside of footnotes!
There was a problem hiding this comment.
I don't know that we want to adjust the spacing on inline code, but I'll leave that up to @kaylachumley and @lboehling to duke it out over. :) My impression was that we just wanted to add a border, but I could be wrong.
Block quotes look good to me; thank you!
|
FWIW here's what it looks like without the padding: 
Wasn't sure either if the padding should be there, or if it was too cramped without any padding. |
|
hmmm im thinking it needs padding! |
|
I'm wondering if an xs spacer would be better padding? The sm padding looks pretty big inline. |
lboehling
left a comment
There was a problem hiding this comment.
+1 to using xs padding on the inline code examples. otherwise, this is good to go!
64c91a7 to
498d06e
Compare
packages/module/src/Message/CodeBlockMessage/CodeBlockMessage.scss
Outdated
Show resolved
Hide resolved
|
🎉 This PR is included in version 6.5.0-prerelease.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #702