Conversation
|
I noticed that the variable name can be changed through the settings and I have created another alternative. |
Yes I've changed the way I did this to use the global window.PhpDebugbar object instead of the variable name. |
|
Althought there isn't really a need to change the var name, because it's in an anonymous scope anyways. |
|
Hmm there can be some timing issues, it seems. Because it's not always directly loaded. Not sure if we can make sure to wait for the parent to load. |
| /** @var \DebugBar\JavascriptRenderer $debugbarRenderer */ | ||
|
|
||
| $debugbarRenderer->setAssetHandlerUrl('../assets.php') | ||
| ->setOpenHandlerUrl('../open.php'); |
There was a problem hiding this comment.
You can avoid this the way I do it; wouldn't that be better?
There was a problem hiding this comment.
It would, but I'm using Laravel herd and that renders /demo in the subfolder, so wouldn't work there.
|
Okay yeah we can just check the global window.top.PhpDebugbar variable, and only check the instance when we're actually adding data. |
|
I tried your solution, the demo doesn't work 100%, My PR This PR |
|
Was that because of your fix in the debugbar or in the settimeout in the demo? |
#959 fixes that, but it doesn't change anything in the code for the debugbar. It's a timing issue because the debugbars aren't initialized yet otherwise. |
No description provided.