Fix type inference for container->get() with string service IDs#2956
Fix type inference for container->get() with string service IDs#2956DaumantasUrb wants to merge 3 commits intophpactor:masterfrom
Conversation
- Use TypeFactory::class() instead of fromString() for proper instance types - Return null instead of object|null when service is not found - Allow custom type resolvers to fully override inferred types This improves type inference accuracy for Symfony DI container get() method by ensuring services return proper reflected class types instead of generic class-string types.
| if (empty($id) || empty($class)) { | ||
| return null; | ||
| } | ||
| // Use TypeFactory::class() to create an instance type |
|
This looks ok... but it's not clear to me what the problem was? in what way(s) is this an improvement? what concrete benefits are there? |
for symfony container - string literals, without phpdoc Previous: 
Updated: 
|
|
ill make a cleaner pr |
|
hm, indeed I see! the only potential issue is erasing the original type information ( it would be nice if the tests were updated to account for the bad behavior, but perhaps it's not that easy |
This improves type inference accuracy for Symfony DI container get() method by ensuring services return proper reflected class types instead of generic class-string types.