Specify MySQL socket file via PMA_SOCKET and PMA_SOCKETS environment …#186
Specify MySQL socket file via PMA_SOCKET and PMA_SOCKETS environment …#186nijel merged 2 commits intophpmyadmin:masterfrom s0m30n3:master
Conversation
…variables Signed-off-by: Évan Goujon <evan.goujon@gmail.com>
|
Following #136 (comment) |
etc/phpmyadmin/config.inc.php
Outdated
| $cfg['Servers'][$i]['AllowNoPassword'] = true; | ||
| } | ||
| for ($i = 1; isset($sockets[$i - 1]); $i++) { | ||
| if (isset($sockets[$i - 1])) { |
There was a problem hiding this comment.
The condition does not make sense here, it's already tested on the loop level. Maybe there should be just one loop with isset($hosts[$i - 1]) && isset($sockets[$i - 1]) condition and this would be used inside of it?
There was a problem hiding this comment.
You're right.
I adapted the code dealing with $hosts but in $sockets case, it's pointless.
Signed-off-by: Évan Goujon <evan.goujon@gmail.com>
|
Merged, thanks for your contribution! |
|
Looping through This is causing troubles for people. |
|
Thank you for reporting this ! |
|
Fixed by 12b0f34 @zhangyoufu |
…variables
Signed-off-by: Évan Goujon evan.goujon@gmail.com