Enable SSL for all server#441
Conversation
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
|
wrong upstream |
If you want you can contribute adding support for SSL via ENVs |
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
|
hi @williamdes, can you review this? |
There was a problem hiding this comment.
Please update https://github.com/phpmyadmin/docker/blob/master/config.inc.php
And run ./update.sh
Can you also add documentation on the README ?
It is unclear how to use this
PMA_SSLS="0,1" is maybe not very user friendly
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
imo this is better to keep it simple as we are not using CA rn. still we are open for suggestion! |
williamdes
left a comment
There was a problem hiding this comment.
Okay, I did not see that other ENVs have the same logic
Please add documentation to the README and say the variable works in the same way that PMA_PORTS works
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
Signed-off-by: TasdidurRahman <tasdid@appscode.com>
|
I sent your changes to the official registry: docker-library/official-images#17398 TODO myself:
|
| - `PMA_SSL` | ||
| - `PMA_SSLS` |
There was a problem hiding this comment.
@TasdidurRahman I am considering a revert of the two lines
It makes no sense to read 1 and 0 from a file
What do you think ?
There was a problem hiding this comment.
sorry for late reply, LGTM
enable ssl connection with upstream. no ca used.
variable introduced:
PMA_SSLfor single upstreamPMA_SSLSfor multiple upstreamdocker run ... -e PMA_HOSTS="mysql-notls,mysql-tls" -e PMA_SSLS="0,1" ...