Fix #19096 blowfish_secret validation: support 64-char hex format and conver…#19599
Open
AMGui63 wants to merge 1 commit intophpmyadmin:masterfrom
Open
Fix #19096 blowfish_secret validation: support 64-char hex format and conver…#19599AMGui63 wants to merge 1 commit intophpmyadmin:masterfrom
AMGui63 wants to merge 1 commit intophpmyadmin:masterfrom
Conversation
…t to binary Signed-off-by: huai.wang <huai.wang@vossic.com> Fix blowfish_secret validation: support 64-character hex format and update documentation Signed-off-by: huai.wang <guanhuaidesu@gmail.com> Signed-off-by: huai.wang <huai.wang@vossic.com> word style Signed-off-by: huai.wang <huai.wang@vossic.com>
MauricioFauth
requested changes
Mar 3, 2025
| // If the key is in hexadecimal and has a length of 64 characters (i.e., 32 bytes), then convert it to binary. | ||
| if ($encryptionKeyLength === 64 && ctype_xdigit($config->settings['blowfish_secret'])) { | ||
| // Convert the hexadecimal string to binary and override the original blowfish_secret | ||
| $binaryKey = hex2bin($config->settings['blowfish_secret']); |
Member
There was a problem hiding this comment.
Please replace the hex2bin function with sodium_hex2bin. The hex2bin function should not be used for cryptography.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix blowfish_secret validation: support 64-character hex format and update documentation
Description
HomeController.phpto allowblowfish_secretas a 64-character hex string.hex2bin().config.sample.inc.phpto reflect the new behavior.docs/config.rst) to explain how users should configureblowfish_secret.Fixes A 64-char hex string should be allowed for the blowfish_secret config directive #19096
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.