Suppress PHP deprecations from third-party packages#19932
Suppress PHP deprecations from third-party packages#19932MauricioFauth wants to merge 3 commits intophpmyadmin:QA_5_2from
Conversation
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
|
If it's just a deprecation why are you suppressing it on 5_2? It's not an error. |
When in development mode, deprecations are converted to exceptions, causing some functionalities to not work correctly. Example from #19837: before1.mp4 |
|
I'm doing this for these third-party packages only, because they released fixes for these deprecations in newer major versions. |
|
What do you think about making the code not convert deprecations to exceptions? I think the concern is that the deprecation might get burried in the HTML response and go unnoticed, but I don't think that's a problem. On 6.0 branch we can still have them throw, but even then, if they are silenced they can still be forgotten. We could also make the deprecations go away in development altogether. |
|
I like the idea, but would rather take it directly to the deprecation error render |
No description provided.