Skip to content

Unset route - $getParams is never empty#20093

Merged
williamdes merged 3 commits intophpmyadmin:masterfrom
liviuconcioiu:20059
Feb 14, 2026
Merged

Unset route - $getParams is never empty#20093
williamdes merged 3 commits intophpmyadmin:masterfrom
liviuconcioiu:20059

Conversation

@liviuconcioiu
Copy link
Contributor

Description

$getParams is never empty, it has atleast the route. Removing it has the same result, if I access the page directly, and will make this code to evaluate.

Before:

08.02.2026_22.19.40_REC.mp4

After:

08.02.2026_22.21.08_REC.mp4

Related to #20059

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@liviuconcioiu liviuconcioiu changed the title Remove $getParams check - is never empty Unset route - $getParams is never empty Feb 12, 2026
@williamdes williamdes added this to the 6.0.0 milestone Feb 14, 2026
@williamdes williamdes self-assigned this Feb 14, 2026
@williamdes williamdes merged commit 5310c0d into phpmyadmin:master Feb 14, 2026
79 of 84 checks passed
@liviuconcioiu liviuconcioiu deleted the 20059 branch February 14, 2026 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants