Unset route - $getParams is never empty#20093
Merged
williamdes merged 3 commits intophpmyadmin:masterfrom Feb 14, 2026
Merged
Conversation
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
williamdes
approved these changes
Feb 9, 2026
This reverts commit 66c03aa.
Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
MauricioFauth
approved these changes
Feb 12, 2026
williamdes
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
$getParamsis never empty, it has atleast the route. Removing it has the same result, if I access the page directly, and will make this code to evaluate.Before:
08.02.2026_22.19.40_REC.mp4
After:
08.02.2026_22.21.08_REC.mp4
Related to #20059
Before submitting pull request, please review the following checklist:
Signed-off-byline as described in our DCO. This ensures that the work you're submitting is your own creation.