You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ah well I see...
Sadly it's quite cumbersome to debug this without being able to build the project locally. At least my PR could be considered as a POC for the neccessary bugfix. Maybe someone else can pick this up where I left off.
Let me restate that it is not possible to just style everything with body > div > * while fixing the related issue. As far as I can tell the darkmode styling needs to be crafted more carefully on a per-element basis.
Edit: Alternatively it might be possible (at least as a temporary solution) to only apply my fix to the documentation pages since I don't see any visual regression results for these pages so I think this should be fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #13574
References: