added warning if globs are used instead of regex#1707
Merged
asottile merged 1 commit intopre-commit:masterfrom Nov 23, 2020
paulhfischer:warn_on_globs_instead_of_regex
Merged
added warning if globs are used instead of regex#1707asottile merged 1 commit intopre-commit:masterfrom paulhfischer:warn_on_globs_instead_of_regex
asottile merged 1 commit intopre-commit:masterfrom
paulhfischer:warn_on_globs_instead_of_regex
Conversation
Member
|
it probably makes more sense in pre_commit/clientlib.py? you can probably add a specific validator for this into the |
Contributor
Author
|
thanks for the hint, i added a validator (+ test) to |
asottile
reviewed
Nov 22, 2020
Member
asottile
left a comment
There was a problem hiding this comment.
looks great! just a few minor improvements
asottile
reviewed
Nov 22, 2020
Member
|
@paulhfischer do you want to implement this for top-level |
Contributor
Author
|
ah that's a good idea! i'll add it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1702