added recursive repository support for golang#1789
Merged
asottile merged 2 commits intopre-commit:masterfrom Feb 6, 2021
paulhfischer:recursive_golang
Merged
added recursive repository support for golang#1789asottile merged 2 commits intopre-commit:masterfrom paulhfischer:recursive_golang
asottile merged 2 commits intopre-commit:masterfrom
paulhfischer:recursive_golang
Conversation
Member
|
oh :/ this was going to be my stream today -- this needs a test |
Contributor
Author
|
oh i'm sorry :/ do you want to do this later today or shall i add a test? |
Member
|
up to you -- the test is the actually interesting part of the patch. you might as well proceed
|
asottile
approved these changes
Feb 6, 2021
Member
asottile
left a comment
There was a problem hiding this comment.
I did some tests with --shared and --reference and --depth=1 and they didn't make a difference in the cloned size so I'm just going to stick to the easiest command here
This was referenced Mar 8, 2021
Closed
This was referenced Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1788
note that i also added
depth=1to reduce cache size and installation time. not sure if the whole command call should be replaced with_shallow_clone, depends on whether you want to keep all command calls within the helper module or not.