Use the correct .git path in case of worktrees. #2252
Merged
asottile merged 1 commit intopre-commit:mainfrom Apr 2, 2022
Merged
Use the correct .git path in case of worktrees. #2252asottile merged 1 commit intopre-commit:mainfrom
asottile merged 1 commit intopre-commit:mainfrom
Conversation
Contributor
Author
|
All green now! |
This fixes the conflicted state check when using work trees. pre-commit#1972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue happens because
get_git_dir()returnsgit rev-parse --git-common-dirand notgit rev-parse --git-diras expected. This PR introducesget_git_common_dir()and uses it where the common dir is required and the local .git dir of the current working copy in all other cases.This fixes #1972, false positives in case of worktrees.
This PR is in the draft state to debug CI issues.