Add tutorials with DuMux and Micro-Manager into system tests#696
Add tutorials with DuMux and Micro-Manager into system tests#696
Conversation
|
To test: trigger the run testsuite manual workflow with:
|
|
I got further in the debugging and now see the error: #21 0.167 Cloning into 'dumux-adapter'...
#21 0.678 error: pathspec 'main' did not match any file(s) known to git
#21 ERROR: process "/bin/bash -c git clone --depth 1 https://github.com/precice/dumux-adapter.git && cd dumux-adapter && if [ -n \"${DUMUX_ADAPTER_PR}\" ]; then git fetch origin pull/${DUMUX_ADAPTER_PR}/head; fi && git checkout ${DUMUX_ADAPTER_REF} && cd .. && dunecontrol --opts=cmake-test.opts --only=dumux-adapter all" did not complete successfully: exit code: 1
------
> [micro-dumux dumux_adapter 6/6] RUN git clone --depth 1 https://github.com/precice/dumux-adapter.git && cd dumux-adapter && if [ -n "${DUMUX_ADAPTER_PR}" ]; then git fetch origin pull/${DUMUX_ADAPTER_PR}/head; fi && git checkout main && cd .. && dunecontrol --opts=cmake-test.opts --only=dumux-adapter all:
0.167 Cloning into 'dumux-adapter'...
0.678 error: pathspec 'main' did not match any file(s) known to git
------It seems like |
|
You are pulling with |
|
With the last manual run of the test suite The manual run before the change to the docker file failed for timeout. Possible reasons are: two times complete compilation of DUNE modules took double the time, or one of this compilations failed build of the adapter, as I built and tested locally to find that the solver can't find the adapter among the other DUNE modules. |
MakisH
left a comment
There was a problem hiding this comment.
Looks good overall, nice to see two new components and tutorials! 🚀
Some minor comments to consider.
Let's wait until the system tests work again (see precice/fenics-adapter#201) before merging (I will do that).
|
Tried to build dumux locally on my machine: Thinks it's safer to increase the |
|
Is there anything blocking this PR? It would be nice to have this merged, as several developments in the DuMuX adapter and the Micro Manager are ongoing, and it would be beneficial to run the system test periodically. |
@IshaanDesai I thought there was still work going on here. I don't see anything else open right now. |
|
Too fast: We still need reference results. I can do that in a follow-up PR. |
|
The system tests now fail earlier. I understood this was already fixed, no? https://github.com/precice/tutorials/actions/runs/22549811465 |
This PR adds dumux, dumux-adapter and Micro Manager into the docker image for system tests and adds dumux-only combinations of the tutorial free-flow-over-porous-media and two-scale-heat-conduction into system test as test suite
dumux_testChecklist:
changelog-entries/<PRnumber>.md.