Skip to content

gh-103857: Document utcnow and utcfromtimestamp deprecations in What's New#104542

Merged
hugovk merged 4 commits intopython:mainfrom
hugovk:docs-whatsnew-utcnow-utcfromtimestamp-deprecations
May 21, 2023
Merged

gh-103857: Document utcnow and utcfromtimestamp deprecations in What's New#104542
hugovk merged 4 commits intopython:mainfrom
hugovk:docs-whatsnew-utcnow-utcfromtimestamp-deprecations

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented May 16, 2023 •
edited
Loading

Re: #103857 (comment), add the deprecations to "What's New in 3.12".

Also fix a typo in a deprecation warning.

And should we clarify these warnings?

    if (PyErr_WarnEx(PyExc_DeprecationWarning,
        "datetime.utcnow() is deprecated and scheduled for removal in a "
        "future version. Use timezone-aware objects to represent datetimes "
        "in UTC: datetime.now(datetime.UTC).", 1))
    if (PyErr_WarnEx(PyExc_DeprecationWarning,
        "datetime.utcfromtimestamp() is deprecated and scheduled for removal "
        "in a future version. Use timezone-aware objects to represent "
        "datetimes in UTC: datetime.fromtimestamp(timestamp, datetime.UTC).", 1))

It's really datetime.datetime.utcnow() and datetime.datetime.utcfromtimestamp(), and not datetime.utcnow() and datetime.utcfromtimestamp().

Reason: to avoid confusion with datetime.UTC (which is not really datetime.datetime.UTC).

📚 Documentation preview 📚: https://cpython-previews--104542.org.readthedocs.build/en/104542/whatsnew/3.12.html#deprecated

@hugovk hugovk requested review from abalkin and pganssle as code owners May 16, 2023 11:35
@bedevere-bot bedevere-bot mentioned this pull request May 16, 2023
Closed
pganssle
pganssle reviewed May 17, 2023
View reviewed changes
@hugovk @pganssle
Fix params in docs
24ef1f3 
Co-authored-by: Paul Ganssle <1377457+pganssle@users.noreply.github.com>
@hugovk hugovk added the docs Documentation in the Doc dir label May 19, 2023
@hugovk
Copy link
Member Author

hugovk commented May 21, 2023

I think everything is ready here, let's merge so it's in Monday's beta, and we can follow up if necessary.

@hugovk hugovk merged commit 5841fbc into python:main May 21, 2023
@hugovk hugovk deleted the docs-whatsnew-utcnow-utcfromtimestamp-deprecations branch May 21, 2023 19:45
@wjandrea wjandrea mentioned this pull request Jul 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle left review comments

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugovk @pganssle @bedevere-bot