Skip to content

Comments

clarify distinction between datetime module and class in deprecation messages#108073

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
neutrinoceros:datetime_utcfromtimestamp_depr_msg
Aug 27, 2023
Merged

clarify distinction between datetime module and class in deprecation messages#108073
serhiy-storchaka merged 1 commit intopython:mainfrom
neutrinoceros:datetime_utcfromtimestamp_depr_msg

Conversation

@neutrinoceros
Copy link
Contributor

@neutrinoceros neutrinoceros commented Aug 17, 2023

I noticed this deprecation warning used datetime to refer to the module and the class on the same line (UTC is a module level constant while fromtimestamp is a class method).

@neutrinoceros neutrinoceros changed the title gh-NNNN: clarify distinction between datetime module and class in deprecation message gh-108073: clarify distinction between datetime module and class in deprecation message Aug 17, 2023
@neutrinoceros neutrinoceros changed the title gh-108073: clarify distinction between datetime module and class in deprecation message clarify distinction between datetime module and class in deprecation message Aug 17, 2023
@neutrinoceros neutrinoceros marked this pull request as ready for review August 17, 2023 09:00
@serhiy-storchaka serhiy-storchaka self-requested a review August 17, 2023 09:18
serhiy-storchaka
serhiy-storchaka reviewed Aug 17, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix also datetime.utcnow()?

@serhiy-storchaka serhiy-storchaka self-requested a review August 17, 2023 09:20
@serhiy-storchaka serhiy-storchaka dismissed their stale review August 17, 2023 09:21

datetime.utcnow

@neutrinoceros neutrinoceros force-pushed the datetime_utcfromtimestamp_depr_msg branch from e0570a5 to 29c0fad Compare August 17, 2023 09:54
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Aug 17, 2023

@serhiy-storchaka done !

@neutrinoceros neutrinoceros changed the title clarify distinction between datetime module and class in deprecation message clarify distinction between datetime module and class in deprecation messages Aug 17, 2023
@neutrinoceros
Copy link
Contributor Author

neutrinoceros commented Aug 18, 2023

Ping @Yhg1s for merge ?

@serhiy-storchaka serhiy-storchaka merged commit 09343db into python:main Aug 27, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Aug 27, 2023

Thanks @neutrinoceros for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 27, 2023

GH-108540 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2023
@neutrinoceros @miss-islington
Clarify distinction between datetime module and class in deprecation …
8990f89 
…messages (pythonGH-108073)

(cherry picked from commit 09343db)

Co-authored-by: Clément Robert <cr52@protonmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 27, 2023
@neutrinoceros neutrinoceros deleted the datetime_utcfromtimestamp_depr_msg branch August 27, 2023 13:34
Yhg1s pushed a commit that referenced this pull request Aug 27, 2023
@miss-islington @neutrinoceros
[3.12] Clarify distinction between datetime module and class in depre…
07c0e24 
…cation messages (GH-108073) (#108540)

Clarify distinction between datetime module and class in deprecation messages (GH-108073)
(cherry picked from commit 09343db)

Co-authored-by: Clément Robert <cr52@protonmail.com>
@ellert
Copy link

ellert commented Sep 7, 2023

Lib/_pydatetime.py says:

warnings.warn("datetime.utcnow() is deprecated and scheduled for ....

Modules/_datetimemodule.c says:

if (PyErr_WarnEx(PyExc_DeprecationWarning,
    "datetime.datetime.utcnow() is deprecated and scheduled for ...

and similar for utcfromtimestamp. Inconsistent.

@neutrinoceros neutrinoceros mentioned this pull request Sep 7, 2023
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@neutrinoceros @miss-islington @bedevere-bot @ellert @serhiy-storchaka