pythongh-111835: Add seekable method to mmap.mmap#111865
pythongh-111835: Add seekable method to mmap.mmap#111865technillogue wants to merge 2 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
4206732 to
9727100
Compare
corona10
left a comment
There was a problem hiding this comment.
FYI, I already opened the PR 7 hours ago.
#111852
And please read the comment about seek() method at #111852 (comment)
|
|
||
|
|
||
| static PyObject * | ||
| mmap_seekable_method(mmap_object *self, PyObject *unused) |
There was a problem hiding this comment.
| mmap_seekable_method(mmap_object *self, PyObject *unused) | |
| mmap_seekable_method(mmap_object *self, PyObject *Py_UNUSED(ignored)) |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
#111852 is merged! |
seekablemethod formmap.mmap#111835