gh-91602: Add iterdump() support for filtering database objects. by felixxm · Pull Request #114501 · python/cpython

felixxm · 2024-01-23T20:54:47Z

Docs changes.
More tests.
Release notes.

Issue: dump of a single table in sqlite3 library #91602

Modules/_sqlite/connection.c

erlend-aasland · 2024-01-24T07:50:33Z

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

felixxm · 2024-01-24T08:03:32Z

I see that the check-if-generated-files-are-up-to-date check still fails; you need to do a full make regen-all, in order to generate the needed static string object for the filter keyword parameter.

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

erlend-aasland · 2024-01-24T08:14:11Z

Thanks for another tip 🎁 I'm not sure why but it also generated some unrelated lines 🤔.

Yeah, that's strange; I'd rebase onto main and make regen-all again 😄

erlend-aasland · 2024-01-24T08:15:47Z

BTW, can you please use git pull --noff main when aligning with main, instead of force pushing? :)

Lib/sqlite3/dump.py

felixxm · 2024-01-24T08:48:53Z

Thanks for all your help, much appreciated. I will work on tests and docs later today.

Modules/_sqlite/connection.c

felixxm · 2024-01-24T19:53:17Z

Now it's ready for review 🎉

Modules/_sqlite/connection.c

erlend-aasland · 2024-01-25T13:02:32Z

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

felixxm · 2024-01-25T13:03:45Z

Very nice; 321b3e0 made the job a lot easier. I still got some nitpicks, so bear with me :)

🍿

erlend-aasland

The refcout refactoring in 8cf51d4 is superb; I was just about to suggest it 🚀. I left a small comment regarding how we do the vector call.

When doing changes that affect reference counting, I normally do a refleak test locally:

$ ./python.exe -m test -R : test_sqlite3

Modules/_sqlite/connection.c

erlend-aasland

After this final change, we should be ready to land.

Modules/_sqlite/connection.c

felixxm · 2024-01-25T19:38:19Z

@erlend-aasland Thanks for all your help 🎁

erlend-aasland

Now for the docs; I left some comments :)

Doc/library/sqlite3.rst

Misc/NEWS.d/next/Library/2024-01-24-20-51-49.gh-issue-91602.8fOH8l.rst

erlend-aasland · 2024-02-03T00:55:09Z

!buildbot .refleak.

bedevere-bot · 2024-02-03T00:55:12Z

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit e314153 🤖

The command will test the builders whose names match following regular expression: .*refleak.*

The builders matched are:

aarch64 RHEL8 Refleaks PR
s390x RHEL8 Refleaks PR
AMD64 Windows11 Refleaks PR
AMD64 Ubuntu NoGIL Refleaks PR
AMD64 Fedora Stable Refleaks PR
ARM64 MacOS M1 Refleaks NoGIL PR
aarch64 Fedora Rawhide Refleaks PR
AMD64 Fedora Rawhide Refleaks PR
PPC64LE Fedora Rawhide Refleaks PR
s390x Fedora Refleaks PR
PPC64LE CentOS9 Refleaks PR
s390x Fedora Rawhide Refleaks PR
PPC64LE RHEL8 Refleaks PR
PPC64LE RHEL7 Refleaks PR
AMD64 CentOS9 Refleaks PR
PPC64LE Fedora Stable Refleaks PR
aarch64 Fedora Stable Refleaks PR
aarch64 CentOS9 Refleaks PR
AMD64 RHEL8 Refleaks PR
s390x RHEL7 Refleaks PR
AMD64 RHEL7 Refleaks PR

erlend-aasland · 2024-02-06T10:15:59Z

The buildbot/s390x Fedora Rawhide Refleaks PR buildbot failure is unrelated to this PR.

erlend-aasland · 2024-02-06T11:35:12Z

Thanks a lot, @felixxm!

…python#114501) Add optional 'filter' parameter to iterdump() that allows a "LIKE" pattern for filtering database objects to dump. Co-authored-by: Erlend E. Aasland <erlend@python.org>

bedevere-app bot mentioned this pull request Jan 23, 2024

dump of a single table in sqlite3 library #91602

Closed

erlend-aasland reviewed Jan 23, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

erlend-aasland reviewed Jan 23, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

felixxm force-pushed the issue-91602 branch from a03f298 to 46302ad Compare January 24, 2024 04:35

pythongh-91602: Add iterdump() support for filtering database objects.

bfad36a

felixxm force-pushed the issue-91602 branch from 46302ad to 9b6b649 Compare January 24, 2024 08:01

erlend-aasland reviewed Jan 24, 2024

View reviewed changes

Lib/sqlite3/dump.py Outdated Show resolved Hide resolved

felixxm added 2 commits January 24, 2024 09:20

Run regen-all.

c414251

Fixed PyObject_Vectorcall() call and SQL placeholder.

b1ae087

felixxm force-pushed the issue-91602 branch from 9b6b649 to b1ae087 Compare January 24, 2024 08:44

More tests.

e181dcb

erlend-aasland reviewed Jan 24, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

Added error handling for Py_*.

048a6a2

erlend-aasland reviewed Jan 24, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

erlend-aasland reviewed Jan 24, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

felixxm added 2 commits January 24, 2024 19:21

Corrected error handling.

f09fa46

Added docs and release notes.

f3bab47

felixxm changed the title ~~[WIP] gh-91602: Add iterdump() support for filtering database objects.~~ gh-91602: Add iterdump() support for filtering database objects. Jan 24, 2024

felixxm marked this pull request as ready for review January 24, 2024 19:52

felixxm requested a review from berkerpeksag as a code owner January 24, 2024 19:52

bedevere-app bot added the awaiting review label Jan 24, 2024

erlend-aasland reviewed Jan 24, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

Used Py_BuildValue().

321b3e0

goto no longer needed.

8cf51d4

erlend-aasland reviewed Jan 25, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

Used PyVectorcall_NARGS().

d993e11

erlend-aasland reviewed Jan 25, 2024

View reviewed changes

Modules/_sqlite/connection.c Outdated Show resolved Hide resolved

Arguments offset.

4de91be

Merge branch 'main' into issue-91602

2036d0a

erlend-aasland reviewed Jan 26, 2024

View reviewed changes

Doc/library/sqlite3.rst Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2024-01-24-20-51-49.gh-issue-91602.8fOH8l.rst Outdated Show resolved Hide resolved

Corrected docs.

e314153

erlend-aasland approved these changes Jan 26, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Jan 26, 2024

Pull in main and regen clinic

3c451df

erlend-aasland merged commit 1a10437 into python:main Feb 6, 2024

bedevere-app bot removed the awaiting merge label Feb 6, 2024

felixxm deleted the issue-91602 branch February 6, 2024 12:05

Uh oh!

Comments

Conversation

felixxm commented Jan 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

erlend-aasland commented Jan 24, 2024

Uh oh!

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixxm commented Jan 24, 2024

Uh oh!

Uh oh!

erlend-aasland commented Jan 25, 2024

Uh oh!

felixxm commented Jan 25, 2024

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

felixxm commented Jan 25, 2024

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Feb 3, 2024

Uh oh!

bedevere-bot commented Feb 3, 2024

Uh oh!

erlend-aasland commented Feb 6, 2024

Uh oh!

erlend-aasland commented Feb 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

felixxm commented Jan 23, 2024 •

edited

Loading