Skip to content

Comments

gh-125703: Correctly honour tracemalloc hooks on more PyDECREF specialized paths#125712

Merged
pablogsal merged 1 commit intopython:mainfrom
pablogsal:gh-125703-2
Oct 21, 2024
Merged

gh-125703: Correctly honour tracemalloc hooks on more PyDECREF specialized paths#125712
pablogsal merged 1 commit intopython:mainfrom
pablogsal:gh-125703-2

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 18, 2024 •
edited by bedevere-app bot
Loading

@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Oct 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2024
Closed
@pablogsal
Copy link
Member Author

pablogsal commented Oct 18, 2024

@markshannon please review this PR. I will not land it until you review it as I don't want to add more fixes like this until we agree on how to fix this problem

If you don't like this approach please tell me what approach you will like.

@pablogsal pablogsal mentioned this pull request Oct 18, 2024
Merged
@markshannon
Copy link
Member

markshannon commented Oct 19, 2024

Since #125704 has already been merged, we may as well merge this for consistency.

I'll make a new issue listing the problems with tracemalloc and the later addition of PyRefTracer_SetTracer causes.
We can discuss solutions there, rather than have them scattered across various issues.

Why the changes to the JIT code? They seem unrelated

@pablogsal
Copy link
Member Author

pablogsal commented Oct 19, 2024

Why the changes to the JIT code? They seem unrelated

That is unrelated indeed. It got incorrectly mixed, will remove 👍

vstinner
vstinner reviewed Oct 21, 2024
View reviewed changes
@pablogsal pablogsal force-pushed the gh-125703-2 branch 2 times, most recently from 9f3e194 to 1e098e9 Compare October 21, 2024 11:23
vstinner
vstinner approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
Copy link
Member Author

pablogsal commented Oct 21, 2024

I will wait for @markshannon to approve

@pablogsal
Copy link
Member Author

pablogsal commented Oct 21, 2024

Landing this per #125703 (comment)

@pablogsal pablogsal merged commit 3d1df3d into python:main Oct 21, 2024
@pablogsal pablogsal deleted the gh-125703-2 branch October 21, 2024 14:39
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 21, 2024

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@pablogsal pablogsal added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Oct 21, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 21, 2024

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2024

GH-125791 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2024
pablogsal added a commit to pablogsal/cpython that referenced this pull request Oct 21, 2024
@pablogsal
[3.13] pythongh-125703: Correctly honour tracemalloc hooks on more Py…
c373c86 
…DECREF specialized paths (pythonGH-125712)

(cherry picked from commit 3d1df3d)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Oct 28, 2024
@pablogsal
[3.13] gh-125703: Correctly honour tracemalloc hooks on more PyDECREF…
00b13ec 
… specialized paths (GH-125712) (#125791)

(cherry picked from commit 3d1df3d)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@pablogsal @ebonnal
pythongh-125703: Correctly honour tracemalloc hooks on more PyDECREF …
0db4286 
…specialized paths (python#125712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pablogsal @markshannon @vstinner