GH-84850: Remove urllib.request.URLopener and FancyURLopener#125739
Merged
hugovk merged 5 commits intopython:mainfrom Nov 19, 2024
Merged
GH-84850: Remove urllib.request.URLopener and FancyURLopener#125739hugovk merged 5 commits intopython:mainfrom
urllib.request.URLopener and FancyURLopener#125739hugovk merged 5 commits intopython:mainfrom
Conversation
These classes have been deprecated since Python 3.3.
vstinner
reviewed
Oct 20, 2024
Member
|
A code search on PyPI top 8,000 projects (at 2024-10-16) on
I didn't check the code to see if imports are conditionals on Python <= 3.3 or not. I ignored Detailscc @hugovk |
Contributor
Author
|
Thanks Victor. From that list, I think about 6 packages are using |
Contributor
Author
|
I believe only four packages would break for users if we removed these classes:
I'll work on PRs if the package authors seem interested. |
Contributor
Author
|
I've submitted PRs against the three projects, one of which has been accepted already. They're all simple changes - in Python 2 terms, we're upgrading from Given that 3.14 is still around a year away, and only 3 projects in 8,000 are affected and possible to remedy at this stage, I submit that we don't need to wait for the other two PRs. Thoughts? |
Member
Agreed, this is definitely on the low side. |
barneygale
commented
Oct 25, 2024
hugovk
approved these changes
Nov 17, 2024
vstinner
reviewed
Nov 18, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
allhailwesttexas
added a commit
to allhailwesttexas/eventlet
that referenced
this pull request
Jun 18, 2025
The class urllib.request.URLopener has been removed in Python 3.14: python/cpython#125739 Because of this, trying to run the tests in `test__greenness.py` fails with the following on Python 3.14: ``` ERROR tests/test__greenness.py - NameError: name 'URLopener' is not defined ``` Update the patching so that we only do it for Python versions lower than 3.14.
allhailwesttexas
added a commit
to allhailwesttexas/eventlet
that referenced
this pull request
Jun 18, 2025
The class urllib.request.URLopener has been removed in Python 3.14: python/cpython#125739 Because of this, trying to run the tests in `test__greenness.py` fails with the following on Python 3.14: ``` ERROR tests/test__greenness.py - NameError: name 'URLopener' is not defined ``` Update the patching so that we only do it for Python versions lower than 3.14.
4383
pushed a commit
to eventlet/eventlet
that referenced
this pull request
Jun 19, 2025
The class urllib.request.URLopener has been removed in Python 3.14: python/cpython#125739 Because of this, trying to run the tests in `test__greenness.py` fails with the following on Python 3.14: ``` ERROR tests/test__greenness.py - NameError: name 'URLopener' is not defined ``` Update the patching so that we only do it for Python versions lower than 3.14. More details: https://docs.python.org/3/library/urllib.request.html#urllib.request.URLopener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These classes have been deprecated since Python 3.3. They originate in Python 2's
urllib, whereas most of the rest of this module comes fromurllib2.📚 Documentation preview 📚: https://cpython-previews--125739.org.readthedocs.build/