gh-126012: Add __class_getitem__ to memoryview#126013
Merged
sobolevn merged 5 commits intopython:mainfrom Oct 27, 2024
Merged
Conversation
picnixz
reviewed
Oct 26, 2024
Member
picnixz
left a comment
There was a problem hiding this comment.
Small nitpicks. We should also add some versionchanged for memoryview objects saying that they are now generics.
Misc/NEWS.d/next/Core and Builtins/2024-10-26-13-32-48.gh-issue-126012.2KalhG.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
…e-126012.2KalhG.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ZeroIntensity
approved these changes
Oct 26, 2024
Member
ZeroIntensity
left a comment
There was a problem hiding this comment.
Might as well hop on the approval train :)
furkanonder
approved these changes
Oct 27, 2024
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com> Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__class_getitem__support tomemoryview#126012📚 Documentation preview 📚: https://cpython-previews--126013.org.readthedocs.build/