GH-123599: Deprecate duplicate pathname2url() implementation#127380
Merged
barneygale merged 5 commits intopython:mainfrom Mar 20, 2025
Merged
GH-123599: Deprecate duplicate pathname2url() implementation#127380barneygale merged 5 commits intopython:mainfrom
pathname2url() implementation#127380barneygale merged 5 commits intopython:mainfrom
Conversation
Call `urllib.request.pathname2url()` from `pathlib.Path.as_uri()`, and deprecate the duplicate implementation in `PurePath`.
nineteendo
reviewed
Nov 29, 2024
AA-Turner
reviewed
Mar 19, 2025
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AA-Turner
approved these changes
Mar 20, 2025
Member
AA-Turner
left a comment
There was a problem hiding this comment.
Thanks! Sorry for missing this PR initially, I only spotted it when you closed the other PR earlier today.
A
Contributor
Author
|
No worries, and thanks very much for the review! Embarrassingly I actually linked the wrong PR from my comment in #123650 😅. I've edited it now. |
Member
Et voilà: #126844 (review) A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
urllib.request.pathname2url()frompathlib.Path.as_uri(), and deprecate the duplicate implementation inPurePath.Path.from_uri()doesn't work if the URI contains host component #123599📚 Documentation preview 📚: https://cpython-previews--127380.org.readthedocs.build/