Skip to content

Comments

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK#127593

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:pidfd
Dec 5, 2024
Merged

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK#127593
vstinner merged 1 commit intopython:mainfrom
vstinner:pidfd

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Dec 4, 2024 •
edited by bedevere-app bot
Loading

@vstinner vstinner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Dec 4, 2024
@bedevere-app bedevere-app bot mentioned this pull request Dec 4, 2024
Closed
@vstinner
Copy link
Member Author

vstinner commented Dec 4, 2024

cc @kumaraditya303

@vstinner vstinner merged commit fcbe6ec into python:main Dec 5, 2024
@vstinner vstinner deleted the pidfd branch December 5, 2024 09:39
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 5, 2024

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2024
@vstinner @miss-islington
pythongh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (pythonGH…
25ff4df 
…-127593)

(cherry picked from commit fcbe6ec)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 5, 2024

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fcbe6ecdb6ed4dd93b2ee144f89a73af755e2634 3.12

@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2024

GH-127630 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 5, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 5, 2024

GH-127631 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 5, 2024
vstinner added a commit that referenced this pull request Dec 5, 2024
@vstinner
[3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (
288d6d0 
#127631)

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593)

(cherry picked from commit fcbe6ec)
vstinner added a commit that referenced this pull request Dec 5, 2024
@miss-islington @vstinner
[3.13] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (GH-127593…
3e11b5c 
…) (#127630)

gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (GH-127593)
(cherry picked from commit fcbe6ec)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 Refleaks 3.12 has failed when building commit 288d6d0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1187/builds/754) and take a look at the build logs.
  4. Check if the failure is related to this commit (288d6d0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1187/builds/754

Failed tests:

  • test_site
  • test_audit

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
remote: Total 12 (delta 1), reused 5 (delta 0), pack-reused 1 (from 1)        
From https://github.com/python/cpython
 * branch                    3.12       -> FETCH_HEAD
Note: switching to '288d6d04aedd62a83a19023f83fc7d1742bfba84'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 288d6d04aed [3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (#127631)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Error 2

@bedevere-bot
Copy link

bedevere-bot commented Dec 5, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL9 Refleaks 3.12 has failed when building commit 288d6d0.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1569/builds/319) and take a look at the build logs.
  4. Check if the failure is related to this commit (288d6d0) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1569/builds/319

Failed tests:

  • test_site
  • test_audit

Summary of the results of the build (if available):

==

Click to see traceback logs 
remote: Enumerating objects: 12, done.        
remote: Counting objects:   9% (1/11)        
remote: Counting objects:  18% (2/11)        
remote: Counting objects:  27% (3/11)        
remote: Counting objects:  36% (4/11)        
remote: Counting objects:  45% (5/11)        
remote: Counting objects:  54% (6/11)        
remote: Counting objects:  63% (7/11)        
remote: Counting objects:  72% (8/11)        
remote: Counting objects:  81% (9/11)        
remote: Counting objects:  90% (10/11)        
remote: Counting objects: 100% (11/11)        
remote: Counting objects: 100% (11/11), done.        
remote: Compressing objects:   9% (1/11)        
remote: Compressing objects:  18% (2/11)        
remote: Compressing objects:  27% (3/11)        
remote: Compressing objects:  36% (4/11)        
remote: Compressing objects:  45% (5/11)        
remote: Compressing objects:  54% (6/11)        
remote: Compressing objects:  63% (7/11)        
remote: Compressing objects:  72% (8/11)        
remote: Compressing objects:  81% (9/11)        
remote: Compressing objects:  90% (10/11)        
remote: Compressing objects: 100% (11/11)        
remote: Compressing objects: 100% (11/11), done.        
remote: Total 12 (delta 1), reused 5 (delta 0), pack-reused 1 (from 1)        
From https://github.com/python/cpython
 * branch                    3.12       -> FETCH_HEAD
Note: switching to '288d6d04aedd62a83a19023f83fc7d1742bfba84'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 288d6d04aed [3.12] gh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (#127593) (#127631)
Switched to and reset branch '3.12'

make: *** [Makefile:2021: buildbottest] Error 2

@kumaraditya303 kumaraditya303 mentioned this pull request Dec 6, 2024
Closed
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@vstinner @srinivasreddy
pythongh-93312: Include <sys/pidfd.h> to get PIDFD_NONBLOCK (python#1…
f2e4894 
…27593)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

@vstinner vstinner

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @bedevere-bot @kumaraditya303