GH-123599: Match file: URL hostname against machine hostname in urllib#132523
Merged
barneygale merged 3 commits intopython:mainfrom Apr 15, 2025
Merged
GH-123599: Match file: URL hostname against machine hostname in urllib#132523barneygale merged 3 commits intopython:mainfrom
file: URL hostname against machine hostname in urllib#132523barneygale merged 3 commits intopython:mainfrom
Conversation
…in urllib In `_is_local_authority()`, return early if the authority matches the machine hostname from `socket.gethostname()`, rather than resolving the names and matching IP addresses.
|
🤖 New build scheduled with the buildbot fleet by @barneygale for commit d3f2555 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132523%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
serhiy-storchaka
approved these changes
Apr 14, 2025
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. This fixes problem on the FreeBSD VM.
There is other failure on OpenBSD VM, but it is a different issue.
Contributor
Author
|
Thanks Serhiy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
_is_local_authority(), return early if the authority matches the machine hostname fromsocket.gethostname(), rather than resolving the names and matching IP addresses.Path.from_uri()doesn't work if the URI contains host component #123599