gh-127987: Ensure that directories are not renamed during tar.TarFile.extractall()#134628
Draft
noamcohen97 wants to merge 10 commits intopython:mainfrom
Draft
gh-127987: Ensure that directories are not renamed during tar.TarFile.extractall()#134628noamcohen97 wants to merge 10 commits intopython:mainfrom
tar.TarFile.extractall()#134628noamcohen97 wants to merge 10 commits intopython:mainfrom
Conversation
Contributor
Author
|
@sethmlarson Please let me know what your thoughts are on this one |
31dddea to
ba8c0f5
Compare
ba8c0f5 to
0e2d157
Compare
it doesn't have to do with this bug
sharktide
suggested changes
May 24, 2025
Contributor
sharktide
left a comment
There was a problem hiding this comment.
A news entry would be best here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most straightforward approach to solving this issue is to re-consult the
filter_functionjust before updating the attributes in the directory withinextract_all(). However, this would result in stateful extraction filters receiving a redundant call for a file that has already passed the filter.Inspired by GNU Tar, I decided to save the exact inode number of the created directory to ensure it hasn't changed.
The only downside I can see is that
stat()is called shortly after the directory is created, which introduces a race condition. Since the entire module is already susceptible to these kinds of races (the path is resolved in thefilter_functionand then re-resolved in the actual file creation methods), I believe this is acceptable.