Improve and extend the _read() method availability for its users and related methods. Part 4: Implement _read() in Dummy()#714
Open
belono wants to merge 5 commits intopython-escpos:masterfrom
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
==========================================
- Coverage 81.39% 81.31% -0.08%
==========================================
Files 21 21
Lines 1693 1697 +4
Branches 267 268 +1
==========================================
+ Hits 1378 1380 +2
Misses 235 235
- Partials 80 82 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This was referenced Oct 9, 2025
Contributor
Author
|
While writing the tests for this feature I realized that the return value of |
Contributor
Author
|
I've added a new test file for the dummy printer that groups the tests for its new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is part 4 of the series to improve and extend the availability of the _read() method.
Part 1: #709
Part 2: #711
Part 3: #712
Part 4: Add the
_read()method to theDummy()connector:This adds an initial implementation of the
_read()method to theDummy()connector that, until now, was lacking this feature and was raising aNotImplementedErrorexception.Note that this is only useful for testing as no real response can be obtained from any printer by the Dummy connector.
Features:
Tests will be added in a later PR.Tested with
Dummy printer