chore: Remove trivial get methods in preparation for generic Get mixin#3110
Merged
nejch merged 1 commit intopython-gitlab:mainfrom Jan 29, 2025
Merged
Conversation
d53c2e3 to
6cdbad3
Compare
igorp-collabora
commented
Jan 29, 2025
Currently because the Get mixin is not generic every subclass has to implement its own `get` methods to type hint `get` method return beoynd the basic RESTObject. The upcoming PR will change Get mixin to use generics. This means it will be able to type hint the corresponding `_obj_cls` and no `get` method would need to be redefined. Because removing existing `get` methods modifies a lot of files split it in to a separate commit. Also remove the `tests/unit/meta/test_ensure_type_hints.py` file because testing subclasses for `get` methods is no longer relevant. Signed-off-by: Igor Ponomarev <igor.ponomarev@collabora.com>
6cdbad3 to
6efad64
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3110 +/- ##
==========================================
+ Coverage 96.80% 97.28% +0.47%
==========================================
Files 97 97
Lines 6358 6006 -352
==========================================
- Hits 6155 5843 -312
+ Misses 203 163 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JohnVillalovos
approved these changes
Jan 29, 2025
Member
JohnVillalovos
left a comment
There was a problem hiding this comment.
WOW! Big PR, but relatively easy to review.
Thanks ❤️
nejch
approved these changes
Jan 29, 2025
Member
nejch
left a comment
There was a problem hiding this comment.
Thanks a lot for splitting this out @igorp-collabora! Seeing all the removals isolated like that is super clear 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently because the Get mixin is not generic every subclass has to implement its own
getmethods to type hintgetmethod return beoynd the basic RESTObject.The upcoming #3083 PR will change Get mixin to use generics. This means it will be able to type hint the corresponding
_obj_clsand nogetmethod would need to be redefined.Because removing existing
getmethods modifies a lot of files split it in to a separate commit.Also remove the
tests/unit/meta/test_ensure_type_hints.pyfile because testing subclasses forgetmethods is no longer relevant.