Skip to content

Consolidate warnings for fixtures missing child devices #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rytilahti merged 1 commit into from
Nov 13, 2024
Merged

Consolidate warnings for fixtures missing child devices #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/fakeprotocol_smart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,10 +200,9 @@ def try_get_child_fixture_info(child_dev_info):
is_child=True,
)
else:
warn(
f"Could not find child SMART fixture for {child_info}",
stacklevel=2,
)
pytest.fixtures_missing_methods.setdefault( # type: ignore[attr-defined]
parent_fixture_name, set()
).add("child_devices")
else:
warn(
f"Child is a cameraprotocol which needs to be implemented {child_info}",
Expand Down