Open
Conversation
jonathanunderwood
previously approved these changes
Oct 16, 2024
Member
|
Approved, but tests failing, so not merging. |
Contributor
Author
|
Will take a look later today, thanks! |
|
I expect it will work after #291. |
822c6d9 to
6c5f600
Compare
Contributor
Author
|
I fucked up while fixing my other PR, but I fixed it now, rebased on top of the original PR and added CI testing. Once #285 gets merged this should get a decent diff instead of having both stacked |
|
I’ve already fixed the ci in #291. You could have rebased on that and saved some time. ;) |
Contributor
|
Please rebase. |
Contributor
Author
|
@cclauss done, apologies for the delay |
Contributor
Author
|
Something is off with the windows tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #278
Running
toxseems to be enough to get a full test