Skip to content

chore: wheel is not required for setuptools#289

Open
henryiii wants to merge 1 commit intopython-lz4:masterfrom
henryiii:patch-2
Open

chore: wheel is not required for setuptools#289
henryiii wants to merge 1 commit intopython-lz4:masterfrom
henryiii:patch-2

Conversation

@henryiii
Copy link

Wheel has never been required in build-system.requires unless you used import wheel in setup.py (which you should not, wheel doesn't have a public API) - it's requested by setuptools via a hook. And modern setuptools doesn't even use wheel anymore.

@jonathanunderwood
Copy link
Member

Builds failing.

@henryiii
Copy link
Author

Same thing on master, too, from what I can tell.

@henryiii
Copy link
Author

henryiii commented Oct 16, 2024

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

You have to keep actions up to date. Old actions stop working. Dependabot can do this, but you need to tell it to group actions, so that upload/download stay in sync.

@cclauss
Copy link
Contributor

cclauss commented Oct 23, 2025

Please rebase.

@henryiii
Copy link
Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants