Revert artifact renaming#294
Merged
jonathanunderwood merged 2 commits intopython-lz4:masterfrom Dec 25, 2024
Merged
Conversation
Member
|
Looks like that broke all the builds... |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
The issue should be here: https://github.com/pypa/gh-action-pypi-publish/blob/release/v1/print-pkg-names.py#L11-L24 So the fix seems to be to just add the extension, which it clearly doesn't do by default (which makes sense, since I'm setting the name). Hopefully this fixes it |
Contributor
Author
|
Build failed due to a timeout, it's on GitHub, not us. If you retry that one it should pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should fix #293
@jonathanunderwood I'm not versed on the upload to PyPI action so I just reverted the renames I introduced