ImportHook cleanup + PyObject.Length exception#1400
Merged
lostmsu merged 5 commits intopythonnet:masterfrom Feb 27, 2021
Merged
ImportHook cleanup + PyObject.Length exception#1400lostmsu merged 5 commits intopythonnet:masterfrom
lostmsu merged 5 commits intopythonnet:masterfrom
Conversation
Member
|
Why do you run the validation only in |
filmor
approved these changes
Feb 27, 2021
9358531 to
908316f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Import
PyImportTest__import__, validates, that__import__was not replaced by a third party (only inDEBUGbuild)_PyObject_GetDictPtrin favor ofPyObject_GenericGetDictPyObject
Length()method now raises an exception when object does not support concept of length (was returning 0).