Fix crash when event does not have Add method and improve message for some other internal errors#2409
Conversation
|
As said, while looking mildly prettier, this still renders the library completely useless in this case. I don't think there is any valid reason for us to bail out on init just because a single type is not loaded properly. So, sure, we can merge this, but we can not claim that it fixes the reported issue. |
|
@filmor the fix is the new null check in The rest is to make it easier to do bug reports: the error data will now at least contain the name of the type that we failed to process. |
|
I see. Still don't see why making |
|
@filmor it does not swallow the error. The checks on methods and fields are different. They actually check that method or field was passed, and not just BTW I was unable to reproduce it with C#. |
What does this implement/fix? Explain your changes.
AddMethodInternalPythonnetExceptionthat can tell user what .NET type caused failure if an unexpected internal error occursDoes this close any currently open issues?
#2405
Checklist
Check all those that are applicable and complete.
CHANGELOG