Fix conversion of elements when iterating over non-generic containers#2680
Closed
brandon-avantus wants to merge 1 commit intopythonnet:masterfrom
Closed
Fix conversion of elements when iterating over non-generic containers#2680brandon-avantus wants to merge 1 commit intopythonnet:masterfrom
brandon-avantus wants to merge 1 commit intopythonnet:masterfrom
Conversation
If the element type of an Iterator is `object`, then query for its actual type before attempting to convert to a Python object. Fixes pythonnet#2679
Author
|
Closing as fixable using a proper encoder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the element type of an Iterator is
object, then query for its actual type before attempting to convert to a Python object.What does this implement/fix? Explain your changes.
This adds a quick check for the element type of an Iterator. If generic element type is
object, then the item type will be used for converting to a Python type instead of the generic type.Does this close any currently open issues?
Fixes #2679
Any other comments?
None.
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG