Update tests to support updated deps which use PSR-4 for tests#364
Merged
clue merged 2 commits intoreactphp:masterfrom Jan 9, 2017
Merged
Update tests to support updated deps which use PSR-4 for tests#364clue merged 2 commits intoreactphp:masterfrom
clue merged 2 commits intoreactphp:masterfrom
Conversation
jsor
approved these changes
Jan 8, 2017
WyriHaximus
approved these changes
Jan 8, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests currently fail due to the updated Travis image setup which no longer supports testing IPv6 connections which the test suite previously relied on.
I've updated the test suite via reactphp-legacy/socket-client#76 and updated the dependency to
socket-client: ^0.5.3but this requires further updates to the test suite in order to now support PSR-4 for our test suites. I've updated thetest/boostrap.phpto account for the new autoload paths and manually added somerequire-devstatements, but I consider this a rather fragile for the future.Anyway, this should fix this for the moment and we can clean this up (or re-consider the whole test suite) in the future 👍