Skip to content

fix(ops): 🐛 prevent RefCell reentrancy panic in combine_latest#267

Merged
wjian23 merged 2 commits intomasterfrom
fix-reborrow-combine-latest
Jan 23, 2026
Merged

fix(ops): 🐛 prevent RefCell reentrancy panic in combine_latest#267
wjian23 merged 2 commits intomasterfrom
fix-reborrow-combine-latest

Conversation

@M-Adoo
Copy link
Collaborator

@M-Adoo M-Adoo commented Jan 22, 2026

Release the mutable borrow of shared state before calling the downstream
observer to allow re-entrant calls in feedback loops.

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 96.87500% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (bda9ba2) to head (5fdb6ee).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/ops/combine_latest.rs 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   82.44%   82.62%   +0.18%     
==========================================
  Files          82       82              
  Lines       11904    12016     +112     
==========================================
+ Hits         9814     9928     +114     
+ Misses       2090     2088       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Release the mutable borrow of shared state before calling the downstream
observer to allow re-entrant calls in feedback loops.
@M-Adoo M-Adoo force-pushed the fix-reborrow-combine-latest branch from 6bd397b to 3ca52a9 Compare January 22, 2026 14:51
@M-Adoo M-Adoo force-pushed the fix-reborrow-combine-latest branch from 3ca52a9 to 5fdb6ee Compare January 22, 2026 14:54
@wjian23 wjian23 merged commit c013a5d into master Jan 23, 2026
12 checks passed
@wjian23 wjian23 deleted the fix-reborrow-combine-latest branch January 23, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants