Skip to content

Comments

feat: geolocation setter in sendgrid-python for GDPR compliance#1073

Merged
shrutiburman merged 22 commits intomainfrom
7.0.0-rc
Nov 23, 2023
Merged

feat: geolocation setter in sendgrid-python for GDPR compliance#1073
shrutiburman merged 22 commits intomainfrom
7.0.0-rc

Conversation

@manisha1997
Copy link
Contributor

@manisha1997 manisha1997 commented Nov 14, 2023 •
edited
Loading

feat!: Geolocation setter for GDPR compliance

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket.

shrutiburman
shrutiburman reviewed Nov 14, 2023
View reviewed changes
shrutiburman
shrutiburman reviewed Nov 14, 2023
View reviewed changes
shrutiburman
shrutiburman reviewed Nov 14, 2023
View reviewed changes
shrutiburman
shrutiburman reviewed Nov 14, 2023
View reviewed changes
shrutiburman
shrutiburman approved these changes Nov 17, 2023
View reviewed changes
Copy link

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manisha1997
Copy link
Contributor Author

manisha1997 commented Nov 17, 2023

@tbischel, What will be the precedence of the host and data_residency.
In case, the user uses both set_host and set_data_residency, we are setting host based on the latest input.

sendgrid-python/test/unit/test_sendgrid.py

Line 19 in 639f14e

def test_host_with_host_first_eu_region_second(self):
,

sendgrid-python/test/unit/test_sendgrid.py

Line 25 in 639f14e

def test_host_with_eu_first_host_second(self):

Can you please clarify if this is correct precedence?

gladysmae08
gladysmae08 reviewed Nov 17, 2023
View reviewed changes
Copy link

@gladysmae08 gladysmae08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR

tbischel
tbischel reviewed Nov 21, 2023
View reviewed changes
tbischel
tbischel reviewed Nov 21, 2023
View reviewed changes
@tbischel
Copy link

tbischel commented Nov 21, 2023

regarding precedence:
I think if they explicitly call the setters, it makes sense to respect the latest called. I think if they pass region and host in the constructor at the same time, we should throw an error if they conflict.

@manisha1997
Copy link
Contributor Author

manisha1997 commented Nov 21, 2023

Makes sense Tyler, thanks.
Will introduce the changes accordingly.

@manisha1997
Copy link
Contributor Author

manisha1997 commented Nov 22, 2023

@tbischel, we decided to remove region and only have a data residency setter.
We removed the set_host as we don't want to expose the function right now #1073 (comment).
Can you please review the changes

tbischel
tbischel reviewed Nov 22, 2023
View reviewed changes
@tbischel
Copy link

tbischel commented Nov 22, 2023

minor nit with the print placement, but other than that LGTM

@tiwarishubham635 tiwarishubham635 self-requested a review November 23, 2023 09:33
@tiwarishubham635
Copy link
Contributor

tiwarishubham635 commented Nov 23, 2023

LGTM!

tbischel
tbischel approved these changes Nov 23, 2023
View reviewed changes
Copy link

@tbischel tbischel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shrutiburman shrutiburman merged commit b5afcca into main Nov 23, 2023
@shrutiburman shrutiburman deleted the 7.0.0-rc branch November 23, 2023 18:59
This was referenced Nov 21, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gladysmae08 gladysmae08 gladysmae08 left review comments

@tbischel tbischel tbischel approved these changes

@shrutiburman shrutiburman shrutiburman approved these changes

+1 more reviewer

@tiwarishubham635 tiwarishubham635 tiwarishubham635 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@manisha1997 @tbischel @tiwarishubham635 @gladysmae08 @shrutiburman