Skip to content

Comments

specify zip_safe=False#5

Merged
smarie merged 5 commits intosmarie:masterfrom
hmaarrfk:patch-1
Aug 31, 2019
Merged

specify zip_safe=False#5
smarie merged 5 commits intosmarie:masterfrom
hmaarrfk:patch-1

Conversation

@hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Aug 7, 2019

Without this it seems to want to pull in ply during build time. Messes with certain packages that disable downloads during setup

@hmaarrfk
specify zip_safe=False
ddb7485 
Without this it seems to want to pull in `ply` during build time. Messes with certain packages that disable downloads during setup
@smarie
Copy link
Owner

smarie commented Aug 7, 2019 •
edited
Loading

Thanks for this PR !
Could you please provide the console output corresponding to the issue you mention ? Indeed there does not seem to be any problem in travis (linux) or on my pc (windows) with several python versions.

@codecov-io
Copy link

codecov-io commented Aug 9, 2019 •
edited
Loading

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          18       18           
  Lines         298      298           
=======================================
  Hits          257      257           
  Misses         41       41

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 134cd2d...0b85486. Read the comment docs.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Aug 9, 2019

See current build log.
These are the default settings for conda-forge for example.

https://travis-ci.org/smarie/python-getversion/jobs/569604484#L458

 pip install . -vv --no-build-isolation

Created temporary directory: /tmp/pip-ephem-wheel-cache-r4jufnwr

Created temporary directory: /tmp/pip-req-tracker-kvx9o1_j

Created requirements tracker '/tmp/pip-req-tracker-kvx9o1_j'

Created temporary directory: /tmp/pip-install-jep1xpni

Processing /home/travis/build/smarie/python-getversion

  Created temporary directory: /tmp/pip-req-build-8_v4i6vx

  Added file:///home/travis/build/smarie/python-getversion to build tracker '/tmp/pip-req-tracker-kvx9o1_j'

    Running setup.py (path:/tmp/pip-req-build-8_v4i6vx/setup.py) egg_info for package from file:///home/travis/build/smarie/python-getversion

    Running command python setup.py egg_info

    /home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/setuptools_scm/git.py:68: UserWarning: "/tmp/pip-req-build-8_v4i6vx" is shallow and may cause errors

      warnings.warn('"%s" is shallow and may cause errors' % (wd.path,))

    zip_safe flag not set; analyzing archive contents...

    Installed /tmp/pip-req-build-8_v4i6vx/.eggs/pandoc-1.0.2-py3.6.egg

    Searching for ply

    Reading https://pypi.org/simple/ply/

    Downloading https://files.pythonhosted.org/packages/a3/58/35da89ee790598a0700ea49b2a66594140f44dec458c07e8e3d4979137fc/ply-3.11-py2.py3-none-any.whl#sha256=096f9b8350b65ebd2fd1346b12452efe5b9607f7482813ffca50c22722a807ce

    Best match: ply 3.11

    Processing ply-3.11-py2.py3-none-any.whl

    Installing ply-3.11-py2.py3-none-any.whl to /tmp/pip-req-build-8_v4i6vx/.eggs

    Installed /tmp/pip-req-build-8_v4i6vx/.eggs/ply-3.11-py3.6.egg

    running egg_info

@smarie
Copy link
Owner

smarie commented Aug 9, 2019

Great. Thanks, I did not know about this!
Please uncomment, and I'll accept the PR

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Aug 9, 2019

I didn't know about it either. caught me by surprise.

@smarie
Copy link
Owner

smarie commented Aug 31, 2019

Thanks. I wonder if True could also be an acceptable value for such a tiny package. But this will wait until someone points it out :)

@smarie smarie merged commit 5a3fba1 into smarie:master Aug 31, 2019
@hmaarrfk hmaarrfk deleted the patch-1 branch August 31, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hmaarrfk @smarie @codecov-io