Skip to content

Fix error with pytest --strict-markers#300

Merged
smarie merged 2 commits intosmarie:mainfrom
chrsmcgrr:feature/283_pytest_strict_markers
Oct 11, 2023
Merged

Fix error with pytest --strict-markers#300
smarie merged 2 commits intosmarie:mainfrom
chrsmcgrr:feature/283_pytest_strict_markers

Conversation

@chrsmcgrr
Copy link
Contributor

Fixes: #283

Proposed fix for the issue where the strict markers mode is enable in pytest.

I took a slightly different approach to the suggested fix in the issue, but I hope it is alright.

Any feedback with regards to testing and implementation would be greatly appreciated.

@smarie
Copy link
Owner

smarie commented Oct 4, 2023

Thanks @chrsmcgrr for this PR !
Could you please pull the latest develop branch so that we can run against all python versions using virtualenv ?

@chrsmcgrr chrsmcgrr force-pushed the feature/283_pytest_strict_markers branch 2 times, most recently from e3e0514 to fda8ea2 Compare October 8, 2023 08:38
@chrsmcgrr
Copy link
Contributor Author

@smarie done! The PR should be good to go.

@smarie smarie merged commit ea22beb into smarie:main Oct 11, 2023
@smarie
Copy link
Owner

smarie commented Oct 11, 2023

Great PR, thanks @chrsmcgrr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marking cases fails when --strict-markers is used

2 participants

Comments