[SofaCUDA] SofaCUDA is now a meta-plugin of two plugins: SofaCUDA.Core and SofaCUDA.Component#5973
Open
fredroy wants to merge 18 commits intosofa-framework:masterfrom
Open
[SofaCUDA] SofaCUDA is now a meta-plugin of two plugins: SofaCUDA.Core and SofaCUDA.Component#5973fredroy wants to merge 18 commits intosofa-framework:masterfrom
fredroy wants to merge 18 commits intosofa-framework:masterfrom
Conversation
Remove dead preprocessor blocks for CUDA_VERSION < 2000, < 3000, and >= 4000, which were never compiled with any CUDA version released since 2008. Collapse multi-branch device info printing in mycuda.cu, keeping only the CUDA_VERSION < 13000 check. Bump minimum CUDAToolkit requirement to 11.0.
741ad22 to
bda8535
Compare
Contributor
|
I think this matters for @sofa-framework/reviewers and possibly @courtecuisse |
bda8535 to
d21c82a
Compare
Contributor
|
So I tried multiple scenes. the python ones you provided work. In the examples some worked and some didn't, so I checkout only this PR to verify if we have regression or not. And it seems to be no regression. |
bakpaul
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the big boi of these PRs
The main point of this PR was to split the tools/core stuff of SofaCUDA and the different component (either specializations or just new instanciations) (+ the GUI done in a previous PR)
A nice side-effect is that plugins depending on SofaCUDA and implementing new components of whatever can now just depends on SofaCUDA.Core.
There are still some confusions such as
It is breaking obviously, but the runtime behavior should be preserved (i.e compat with the scenes)
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if