Solver changes without eigen#1158
Merged
phkahler merged 9 commits intosolvespace:masterfrom Dec 30, 2021
Merged
Conversation
phkahler
reviewed
Dec 24, 2021
Member
phkahler
left a comment
There was a problem hiding this comment.
I can't speak to the more complex changes, but nothing "looks wrong".
Contributor
Author
|
With this plus the "no sparse expr" pr, I can actually say I understand the Jacobian code moderately ok now, at least the part about computing and evaluating it. Haven't looked at the other methods in the file enough to learn those. For a fun time, look at branches I pushed to my fork recently named things like "another way to cause memory corruption" 😅. I should probably script running over the test case repo with sanitizers on to make sure it works on more than just the normal test suite and the 2 models I tested on . |
1. We are making FoldConstants first, so we are copying less amount of data in DeepCopyWithParamsAsPointers. 2. Since we already perform DeepCopyWithParamsAsPointers, PartialWrt already produces params as pointers
(Split out from earlier "Eigen library integration" commit)
Split from previous large 'Eigen library integration' commit.
ee28073 to
7b03bd6
Compare
Contributor
Author
|
OK this has been rebased, now builds on #1155 to simplify the history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just the solver changes from #721, skipping the final commits that add Eigen, and fixed so that every commit successfully builds. I do not fully understand the changes, I just can rebase them sensibly. @Evil-Spirit is the real author here.
I'll put the Eigen stuff in a separate PR.
This does run.
With sanitizers enabled, looks like no new leaks thru here.