Skip to content

Revert "mac: Don't interpret single-touch scroll events as pan gestures"#1218

Merged
phkahler merged 1 commit intomasterfrom
revert-mouse-magic
Feb 28, 2022
Merged

Revert "mac: Don't interpret single-touch scroll events as pan gestures"#1218
phkahler merged 1 commit intomasterfrom
revert-mouse-magic

Conversation

@vespakoen
Copy link
Contributor

This reverts commit 91db627.

@phkahler phkahler merged commit b429141 into master Feb 28, 2022
@ruevs ruevs deleted the revert-mouse-magic branch February 28, 2022 16:28
@nanoant
Copy link
Contributor

nanoant commented Jul 26, 2022

Sorry to bother you @vespakoen and @phkahler but why did you revert this? Unfortunately there's no description given in this PR.
Now Magic Mouse again acts like a touch pad (again), and there's no way to zoom anymore with the mouse.
I though we had this settled in #1106 but now I'd need to open #1106 again? Or am I missing something 😮

@ruevs
Copy link
Member

ruevs commented Jul 26, 2022

The discussion that lead to this rollback is towards the end of #1107 (I think, I don't follow Mac too closely since I don't have a modern one). @tomsci should be able to explain it.

@nanoant
Copy link
Contributor

nanoant commented Jul 26, 2022

Thanks @ruevs! I'll continue there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants