Skip to content

Comments

Update README install and build guides#1673

Closed
wolfpackmars2 wants to merge 1 commit intosolvespace:masterfrom
wolfpackmars2:patch-2
Closed

Update README install and build guides#1673
wolfpackmars2 wants to merge 1 commit intosolvespace:masterfrom
wolfpackmars2:patch-2

Conversation

@wolfpackmars2
Copy link
Contributor

@wolfpackmars2 wolfpackmars2 commented Feb 4, 2026

Added instructions for installing via unofficial distro packages and additional information when building from source for various platforms.

Changed header from "Via Source Code" to "Getting the source code". Added a target to not break existing links.

Fix other small typos and grammar.

Resolves #1654 and resolves #1653

Added instructions for installing via unofficial distro packages and additional information when building from source for various platforms.

Changed header from "Via Source Code" to "Getting the source code". Added a target to not break existing links.

Fix other small typos and grammar.

Resolves solvespace#1654 and solvespace#1653
@wolfpackmars2
Copy link
Contributor Author

I've reviewed the entirety of the readme and propose a few changes for readability and to add additional information for reference. Particularly for users who wish to build/install on Linux.

I moved the header "Via source code" from the Installation group and made a master header for building from source code. In this context, leaving the header as "via source code" didn't quite fit the new section. To prevent any existing web links to the old heading, I added a custom anchor to maintain the old links.

@ruevs ruevs marked this pull request as draft February 4, 2026 20:26
@ruevs
Copy link
Member

ruevs commented Feb 4, 2026

This is too intrusive. The new information is superfluous (easy to google); the restructuring is unnecessary.

DCMAKE_INSTALL_PREFIX=~/.local] hmm... No? Let whoever is not root figure it out... They should be able to, if they set out compiling software on Linux.

Moving the "building on OpenBSD" section - no.

The grammar and spelling fixes are good. If you submit a PR with just them I'll merge it (or I'll make them myself).

@wolfpackmars2
Copy link
Contributor Author

I apologize for my presumptuousness.

@ruevs
Copy link
Member

ruevs commented Feb 5, 2026

@wolfpackmars2 you do not need to apologise. I appreciate the fact that after figuring out the make install without root privileges you spent the time to go through the readme and update it. Even though I think the new information does not belong in the main README.md - it is long enough already - do not take it personally. This PR will remain and may help someone facing a similar problem in the furlture.

And the grammatical and spelling errors you caught are really appreciated! Obviously no one read carefully enough before you :-)

@wolfpackmars2
Copy link
Contributor Author

wolfpackmars2 commented Feb 20, 2026

Thanks for the feedback @ruevs

I remember why I was frustrated that day. I spend a lot of effort trying to provide quality PR while respecting the time of the core team. For this reason I spend a lot of time researching - for example, to try to identify if the code in its current state is intentional, and definitely to try to identify any way the change could negatively impact the project or the core team.

I wasn't expecting pushback on my PR, which I see as fixing a typo. The concerns raised in the feedback there are separate from what the PR actually does, and I wasn't sure how to best respond or even if I should spend any more time on something that was going to be removed anyways.

This isn't the first time I've been slapped back for suggesting structural changes to documentation, so indeed I take responsibility for overstepping in this regard.

@wolfpackmars2
Copy link
Contributor Author

DCMAKE_INSTALL_PREFIX=~/.local] hmm... No? Let whoever is not root figure it out... They should be able to, if they set out compiling software on Linux.

Not necessarily. Following good instructions to compile a program is easy. It doesn't require knowledge of how cmake works or how the project is set up for cmake.

I have determined that sudo is not needed to install SS, and I wanted to provide the information so that people who aren't experienced specifically with cmake but who can build from source can have the choice without having to spend hours (like I did) to figure it out.

I don't see why providing this information in the guide would cause a problem. If the information can be presented differently, or if the information causes other problems (ie confusion, is inaccurate, etc) then I would be receptive to such feedback.

I can only accept your decision in my current position, but it would be helpful to me to understand the potential negative effects of adding this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate sudo requirement for make install Linux: Update metainfo for SolveSpace after install

2 participants