Fix FDW previews when column names have percentage signs #619
Merged
Fix FDW previews when column names have percentage signs #619
Conversation
These column names issues when using argument interpolation, as psycopg2 treats them as arguments and raises an IndexError (not enough arguments). Fix by escaping them with double-percentage signs. Note that this isn't fixed everywhere, just on the FDW data source preview code path. Also add a test using a CSV file with a percentage sign, as this is how this bug was first discovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These column names issues when using argument interpolation, as psycopg2 treats
them as arguments and raises an IndexError (not enough arguments). Fix by
escaping them with double-percentage signs.
Note that this isn't fixed everywhere, just on the FDW data source preview code
path.
Also add a test using a CSV file with a percentage sign, as this is how this bug
was first discovered.