Import Callable from typing for Python 3.10 compat#704
Merged
Conversation
Contributor
onpaws
commented
Jul 18, 2022
- Python 3.10 no longer provides Callable in collections
- We now import it from typing, to be consistent with previous imports
- See https://docs.python.org/3/whatsnew/3.10.html#pep-612-parameter-specification-variables
- Python 3.10 no longer provides Callable in collections - We now import it from typing, to be consistent with previous imports - See https://docs.python.org/3/whatsnew/3.10.html#pep-612-parameter-specification-variables
5f42581 to
cce540c
Compare
Contributor
|
Thanks! The test failure is due to a different reason (fails on other branches too) so I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.