Skip to content

Import Callable from typing for Python 3.10 compat#704

Merged
mildbyte merged 1 commit intomasterfrom
bugfix/callable-py3.10-compat
Jul 19, 2022
Merged

Import Callable from typing for Python 3.10 compat#704
mildbyte merged 1 commit intomasterfrom
bugfix/callable-py3.10-compat

Conversation

@onpaws
Copy link
Contributor

@onpaws onpaws commented Jul 18, 2022

- Python 3.10 no longer provides Callable in collections
- We now import it from typing, to be consistent with previous imports
- See https://docs.python.org/3/whatsnew/3.10.html#pep-612-parameter-specification-variables
@mildbyte
Copy link
Contributor

Thanks! The test failure is due to a different reason (fails on other branches too) so I'll merge this.

@mildbyte mildbyte merged commit ec4904c into master Jul 19, 2022
@mildbyte mildbyte deleted the bugfix/callable-py3.10-compat branch July 19, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants