Skip to content

test: add methodselect unit testing#613

Open
BenjaminGoehry wants to merge 1 commit intostackql:mainfrom
BenjaminGoehry:test/methodselect
Open

test: add methodselect unit testing#613
BenjaminGoehry wants to merge 1 commit intostackql:mainfrom
BenjaminGoehry:test/methodselect

Conversation

@BenjaminGoehry
Copy link

@BenjaminGoehry BenjaminGoehry commented Feb 6, 2026

Closes #242

Summary:

Add comprehensive unit tests for the methodselect package, covering all core functions:

  • GetMethodForAction: Tests supported actions (SELECT, mixed case), unsupported actions, and error handling.
  • GetMethod: Tests retrieval of existing and non-existent methods.
  • getMethodByNameAndParameters: Tests method lookup with and without parameters.
  • NewMethodSelector: Tests initialization for supported and unsupported providers.
    All tests use the aws provider and bucket_acls resource for consistency.
image

@BenjaminGoehry BenjaminGoehry marked this pull request as ready for review February 6, 2026 15:35
@general-kroll-4-life
Copy link
Contributor

@BenjaminGoehry thanks for the contribution. Can you please attend tot he linting error, at the time of writing this is Error: internal/stackql/methodselect/methodselect_test.go:1:9: package should be methodselect_testinstead ofmethodselect (testpackage)

@BenjaminGoehry
Copy link
Author

@general-kroll-4-life Thanks, I updated it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit testing for package methodselect

2 participants