feat: add stats/array/nanmskmidrange#10224
Merged
Planeshifter merged 3 commits intostdlib-js:developfrom Feb 15, 2026
Merged
Conversation
Member
Author
|
/stdlib update-copyright-years |
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
requested changes
Feb 14, 2026
Comment on lines
67
to
69
| nanmskmidrange(); // $ExpectError | ||
| nanmskmidrange( x, {} ); // $ExpectError | ||
| nanmskmidrange( x, mask, {} ); // $ExpectError |
Member
There was a problem hiding this comment.
This should test that too few arguments is an error (i.e., nanmskmidrange( x )) rather than nanmskmidrange( x, {} ), which duplicates the second argument type error tests from the block above. The reference mskmidrange test.ts has mskmidrange( x ); here.
Suggested change
| nanmskmidrange(); // $ExpectError | |
| nanmskmidrange( x, {} ); // $ExpectError | |
| nanmskmidrange( x, mask, {} ); // $ExpectError | |
| nanmskmidrange(); // $ExpectError | |
| nanmskmidrange( x ); // $ExpectError | |
| nanmskmidrange( x, mask, {} ); // $ExpectError |
|
|
||
| #### nanmskmidrange( x, mask ) | ||
|
|
||
| Computes the midrange of an array according to a mask, ignoring `NaN` values. |
Member
There was a problem hiding this comment.
The function description here should link to the [midrange] definition, matching the reference mskmidrange package which uses Computes the [midrange][midrange] of an array according to a mask.
Suggested change
| Computes the midrange of an array according to a mask, ignoring `NaN` values. | |
| Computes the [midrange][midrange] of an array according to a mask, ignoring `NaN` values. |
|
|
||
| [@stdlib/array/base/accessor]: https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/array/base/accessor | ||
|
|
||
| [midrange]: https://en.wikipedia.org/wiki/Midrange |
Member
There was a problem hiding this comment.
Suggested change
| [midrange]: https://en.wikipedia.org/wiki/Midrange | |
| [midrange]: https://en.wikipedia.org/wiki/Mid-range |
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves None.
Description
This pull request:
stats/array/nanmskmidrangeRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers