Skip to content

chore: fix Javascript lint errors (issue #10264)#10266

Merged
Planeshifter merged 2 commits intostdlib-js:developfrom
bhargava-d16:chore-lint-error-10264
Feb 16, 2026
Merged

chore: fix Javascript lint errors (issue #10264)#10266
Planeshifter merged 2 commits intostdlib-js:developfrom
bhargava-d16:chore-lint-error-10264

Conversation

@bhargava-d16
Copy link
Contributor

@bhargava-d16 bhargava-d16 commented Feb 14, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: na
  • task: lint_package_json status: na
  • task: lint_repl_help status: na
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: na
  • task: lint_javascript_tests status: na
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: na
  • task: lint_license_headers status: passed ---

Resolves #10264

Description

What is the purpose of this pull request?

This pull request:

  • Fixes JavaScript lint errors by moving function done to outer function scope

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

@bhargava-d16
chore: fix Javascript lint errors (issue stdlib-js#10264)
6a56688 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added Tools Issue or pull request related to project tooling. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Feb 14, 2026
@Planeshifter
Copy link
Member

Planeshifter commented Feb 14, 2026

Thanks for the contribution! The functional change looks correct -- hoisting done to the outer factory scope fixes the stdlib/no-unnecessary-nested-functions lint error.

Two things to address:

  1. JSDoc indentation: The JSDoc comment for done still uses the old double-tab indentation from when it was nested inside fetchFile. Since done is now at the same scope level as fetchFile, its JSDoc should use single-tab indentation to match. See the inline comment for a suggestion.

  2. PR title / commit message: The issue instructions specify "chore: fix JavaScript lint errors (issue #)" but the title uses "Javascript" (lowercase 's'). Please update to "JavaScript" (capital 'S') to match the proper name of the language.

@bhargava-d16
chore: fix JavaScript lint errors (issue stdlib-js#10264)
df7bd51 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@bhargava-d16
Copy link
Contributor Author

bhargava-d16 commented Feb 15, 2026

@Planeshifter I have made the requested changes. Please let me know if there are any further changes to be made

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 15, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 15, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 15, 2026 •
edited by Planeshifter
Loading

PR Commit Message

chore: fix JavaScript lint errors

PR-URL: https://github.com/stdlib-js/stdlib/pull/10266
Closes: https://github.com/stdlib-js/stdlib/issues/10264

Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit f47fc46 into stdlib-js:develop Feb 16, 2026
27 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Tools Issue or pull request related to project tooling.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix JavaScript lint errors

3 participants

@bhargava-d16 @Planeshifter @stdlib-bot