PROD 2198 Databricks Datatype Replacement in sync_backend#1
Conversation
…om:synccomputingcode/databricks-sdk-py into PROD-1894-databricks-datatype-replacements
databricks/sdk/service/compute.py
Outdated
| - Name: <Databricks internal use>""" | ||
|
|
||
| disk_spec: Optional[dict] = None | ||
| """An APC attribute only. This field is missing in the API docs and the unforked databricks |
There was a problem hiding this comment.
[PROD-1234] An APC attribute only. This field is missing in the API docs and the unforked databricks ....
|
Hey Cayman, this looks great! One thing that I've learned that will make our lives a lot easier, I would open a jira ticket with a description of these changes (just like you have here) and then preface each of your comments with that ticket. This makes it really easy to find all of the changes that we made rather than having to per-file history investigation |
singhals
left a comment
There was a problem hiding this comment.
@CaymanWilliams @vinooganesh - we should consider extending these models in sync_backend instead of forking the repo. Forking will lead to a lot of tech debt for us where as extending the models keeps us following our existing checks and patterns to manage library versions.
Changes
Made a couple model changes to deal with inconsistencies in the models that we want to use in sync_backend for PROD-1984
Tests
This is mostly tested in the corresponding branch of sync_backend but all the existing tests here still seem to pass even with these changes
make testrun locallymake fmtapplied