Fix package method error#88
Merged
nicekiwi merged 2 commits intosyntaxerrors:masterfrom Apr 23, 2019
Teakowa:fix-package-method-error
Merged
Fix package method error#88nicekiwi merged 2 commits intosyntaxerrors:masterfrom Teakowa:fix-package-method-error
nicekiwi merged 2 commits intosyntaxerrors:masterfrom
Teakowa:fix-package-method-error
Conversation
Remove `formatPriceObject` method in Containers/Package.php price, it should be the same as the Containers/App.php
Correct `packahe` to `package` in test/BaseTester.php
Collaborator
|
Ha! Good catch on the typos. Unit tests are currently broken. I'm working on fixing; but I'm happy with this as is. :) thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong method included in #74, some spelling mistake, and changed test package id.